search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

support jruby9k for system extensions #153

Closed mmmries closed 9 years ago

mmmries commented 9 years ago

Brakeman started crashing for us when we switched to jRuby 9000. It looks like you already have this fixed up for the 2.0 series, but I think it would be worth it to add a patch for the 1.7 series because there are a lot of dependencies out there that specify 1.X in their gemspec files (ie steps, progress_bar, brakeman...)

abinoam commented 9 years ago

Thank you very much for the PR @mmmries Merging.

abinoam commented 9 years ago

@JEG2 , I have updated the Changelog and upgraded the version up to 1.7.5 at the 1-7-stable branch. Could you do gem release?

mmmries commented 9 years ago

Many thanks for the fast merge. I hope this is helpful for lots of other developers using jRuby + highline

:heart: :heart_eyes: :heart: :heart_eyes: :heart: :heart_eyes: :heart: :heart_eyes:

@JEG2 remember that time you invited me onto the ruby rogues? Still a highlight for me! Thanks for all your work making this library.

JEG2 commented 9 years ago

I do remember. The Vagrant episode. It was good stuff.

Gem released. Thanks!