search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Rebased PR #184 (original by @matrinox) #186

Closed abinoam closed 8 years ago

abinoam commented 8 years ago

Hi @matrinox,

I have rebased your branch to remove the comes forth and goes back.

I removed that last commit that sacrifices the ability to pass a MenuItem directly. Looking more carefully I think your previous version was better (and my suggestions only messed things).

I'll merge this rebased version ok?

abinoam commented 8 years ago

cc #184

matrinox commented 8 years ago

I added a few more commits, up to a118d10. If you like them add it here and then we can merge!

abinoam commented 8 years ago

Hi @matrinox, I have just cherry picked your last commits and made some small adjustments.

But I'm finding strange that GitHub is not respecting the commit order/sorting of my commit history. Just trying to fix this minor issue.

abinoam commented 8 years ago

https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/

abinoam commented 8 years ago

Well, just tested from another computer and commits are in proper order/sorting.

abinoam commented 8 years ago

Dear @matrinox,

Thank you very much for your PR and the discussions we've had. Sorry for not being as fast to answer your comments as you deserve. And we hope you keep contributing to HighLine.

Merging into master!

cc: @JEG2 I think we're ready to release 2.0.0.develop.6 version (I have already updated VERSION).

matrinox commented 8 years ago

:+1:

JEG2 commented 8 years ago

Release made. I'm excited. :smile: