search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

confirm in question now accepts Proc #201

Closed mmihira closed 8 years ago

mmihira commented 8 years ago

Implemented functionality to assign a Proc object to the confirm attribute of the Highline::Question object.

abinoam commented 8 years ago

Closes #201

See:

abinoam commented 8 years ago

Could you add a test for it?

Could you also please update the documentation (comment) adding this new functionality? https://github.com/JEG2/highline/blob/master/lib/highline/question.rb#L149

And also update the Changelog.md so it cites the addition and gives credit to you?

If you need any assistance in any of these, please tell me, I would be glad to help you along.

And thank you for the pull request, we'll be merging it as soon as it's complete. 👍

mmihira commented 8 years ago

I just made a test, updated the docs and also added an entry in the change log. Thank you for the clear guidance. Let me know if there are any other issues.

abinoam commented 8 years ago

Great @mmihira !

abinoam commented 8 years ago

As soon as you fix the tiny typo we're gonna merge. It'll be perfect with tests and everything. Thank you in advance.

mmihira commented 8 years ago

Thanks @abinoam. I fixed up the typo.

abinoam commented 8 years ago

I have merged it into master. It will be on the next release. Thank you very much @mmihira! 👍