JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Remove the use of $terminal global variable #214

Closed abinoam closed 7 years ago

abinoam commented 7 years ago

To maintain minimum back compatibility we will follow these steps at the internals:

Although we're still relying on a global state at least now we're namespaced on HighLine and we now avoid name collisions that have happened at the past with $terminal global var (as terminal is a very common word).

abinoam commented 7 years ago

@JEG2 as I said at the top

Although we're still relying on a global state at least now we're namespaced on HighLine and we now avoid name collisions that have happened at the past with $terminal global var (as terminal is a very common word).

Basically it deprecates the use of $terminal and uses HighLine.default_instance.

So... merging.

JEG2 commented 7 years ago

Love this.