Closed abinoam closed 7 years ago
@JEG2 as I said at the top
Although we're still relying on a global state at least now we're namespaced on HighLine and we now avoid name collisions that have happened at the past with $terminal global var (as terminal is a very common word).
Basically it deprecates the use of $terminal
and uses HighLine.default_instance
.
So... merging.
Love this.
To maintain minimum back compatibility we will follow these steps at the internals:
HighLine instance
after definition ofHighLine
classHighLine.default_instance
$terminal
now we do withHighLine.default_instance
Although we're still relying on a global state at least now we're namespaced on HighLine and we now avoid name collisions that have happened at the past with
$terminal
global var (as terminal is a very common word).