search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

test failing when ruby is built against libedit instead of readline #247

Open boutil opened 3 years ago

boutil commented 3 years ago

Hi,

Recently, Debian started to build the ruby interpreter against libedit instead of readline for license reasons: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977724 One test in highline gem started to fail after this change:

  1) Failure:
TestHighLine#test_readline_mode [/tmp/autopkgtest-lxc.ln2dsy6w/downtmp/build.OjD/src/test/test_highline.rb:391]:
Expected /Prompt:\ \ any\ input\n/ to match "Prompt:  ".

170 runs, 1089 assertions, 1 failures, 0 errors, 3 skips

(see e.g.: https://ci.debian.net/data/autopkgtest/testing/amd64/r/ruby-highline/10349342/log.gz)

This does not seem to have an influence on other packages in Debian depending on this library though.

abinoam commented 3 years ago

Thanks for reporting. I can't make any promise when I could see this. I welcome any PR to fix it.

abinoam commented 3 years ago

Perhaps it's time for us to search again for a pure ruby readline implementation.

kbrock commented 1 year ago

irb uses https://github.com/ruby/reline Would something like that meet the needs?

Sorry I haven't had the chance to test it out not drop it into here.

Per some reline PRs, it looks like in ruby 3.3, readline will be aliases to reline. And there are some possibly issues with configuration (at the current time).

So moving across and ensuring compatibility before the switch may be a good thing. Or the problem may just go away.