remove unused abbrev dependency

zvkemp commented 9 months ago

It looks like the only usage of abbrev was removed in https://github.com/JEG2/highline/commit/9994c6608f0dc12d228c1c12a7e75784a3fd1fef.

calebhearth commented 9 months ago

FWIW, abbrev being around is causing errors that seem to be caused by Zeitwerk, but are actually coming from this gem:

/Users/caleb/.gem/ruby/2.6.10/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38: warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby
 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.12 to add abbrev into its gemspec.

❯ ag "require .abbrev." .gem                                                                                                                                          
.gem/ruby/3.3.0/gems/highline-2.1.0/lib/highline.rb                                                                                                                                          
17:require "abbrev"                                                                                                                                                                          

.gem/ruby/3.2.2/gems/highline-2.1.0/lib/highline.rb                                                                                                                                          
17:require "abbrev"

abinoam commented 9 months ago

Nice spot! Thank you very much both of you. My bad for not checking its use before previous release. I'll merge it and release it.

abinoam commented 9 months ago

Released :rocket:

https://rubygems.org/gems/highline/versions/3.0.1

JEG2 / highline

remove unused abbrev dependency #268