search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Remove shebangs #38

Closed sgonyea closed 12 years ago

sgonyea commented 12 years ago

Hi, I'm sorry for this pull request. But let me explain...

First, I use highline in my project, so thank you for creating it :).

Second, my project is built into an RPM and that is how it gets deployed. I'm a pretty weird person.

So, why the pull request? Because RPM scans your files and whenever it sees a shebang, it automatically adds that shebang to the list of dependencies. Because my project (no longer!) has a /usr/local/bin/ruby, I now get this error:

error: Failed dependencies:
    /usr/local/bin/ruby is needed by my_project-TRUNK-347.x86_64

Due to highline placing that in all of its files. Threw me off at first, too. But it's only the highline gem that has this baked in. I'm adding in a hack to scrub it for now, but it'd be really nice if I didn't need to defensively scrub the install files for my gems :).

Thank you very much.

JEG2 commented 12 years ago

I think it's probably better to just remove these shebang lines. They aren't really serving any purpose here.

If you modify the request to do that, I'll merge it.

sgonyea commented 12 years ago

Cool, thank you. Doing it now.

sgonyea commented 12 years ago

This is done! Thank you. Any chance you could cut this as a new gem?

JEG2 commented 12 years ago

Oops, my bad. I wasn't clear.

Please do leave the shebangs on example files. The env version is fine. Remove them from library and test files only.

Sorry.

sgonyea commented 12 years ago

Done! No problem, and thank you :).

JEG2 commented 12 years ago

Version 1.6.13 has been pushed to the gem server with your changes.

sgonyea commented 12 years ago

Thank you very much.