added time that takes to complete udf format.

[ferdna]

time taken to complete udf format on device.

[JElchison]

hi @ferdna! thanks for your pull request. i always appreciate when folks are willing to invest in open source software.

i'll be honest, i'm having a hard time understanding the utility of your update. it seems to be taking steps away from the Unix philosophy instead of steps toward it.

i see how your recommended change can be useful for debugging, but i'm failing to see how it provides actionable information to the nominal user. can you help me understand your goal?

i can definitely see a case in which a user would like to know how long it takes format-udf to run altogether, but that could easily be accomplished by:

time ./format-udf.sh ...

i'm having trouble understanding what use a nominal user could have for understanding what portion of the execution time was spent on the format operation itself (which is only one of several significant operations completed in the script).

further critique on your implementation:

• you seem to have broken quoting. you attempted to wrap the entire format sequence in double quotes ("), but yet what you wrapped already used double quotes. i think i can create a sequence that causes the script to error out in a way that it did not before.
• you seem to have broken the rule of least privilege, as now additional commands fall under the sudo umbrella.
• it may not be necessary to use sh -c at all, as the script already operates in a POSIX-compliant bash

those critiques aside, i'd like to learn more from you about what value you think your patch adds for the nominal user.

thanks!

[JElchison]

hi @ferdna, it's been over 4 months, so i'm assuming you've dropped this. as such, i'll go ahead and close this issue. if, at any point, you pick it back up, feel free to re-comment to discuss. thanks!