search

JElchison / format-udf

Bash script to format a block device (hard drive or Flash drive) in UDF. The output is a drive that can be used for reading/writing across multiple operating system families: Windows, macOS, and Linux. This script should be capable of running in macOS or in Linux.
GNU General Public License v2.0
518 stars 48 forks source link

Script fails with udftools 2.0+ #40

Closed lafleurdeboum closed 6 years ago

lafleurdeboum commented 6 years ago

The script as is failed in Ach linux, using udftools 2.0-2 ; the error was :

mkudffs: Error: Option --media-type must be specified before option --udfrev

So I just edited the script ; I moved the --media-type option before the --udfrev option and retried. It then worked fine. I'm sending the diff attached.

Thank you for this great script anyway ! format-udf.sh.diff.zip

JElchison commented 6 years ago

Thanks for the report!

Looks like this was introduced recently in https://github.com/pali/udftools/commit/3aef27189e3229c5ef3af3d199c2c0bee9c2c209

Are you willing to submit your fix as a pull request? If not, no worries, I'll manually replicate your diff.

lafleurdeboum commented 6 years ago

Yes, I'll be glad to submit it as a pull request, let me try to do it, that'll be my first time ! :-)

JElchison commented 6 years ago

Great! If it's too much trouble, I'm happy to take care of it. But if you submit a PR, your name will live on in the format-udf history for all time. :)

If you'd like some tips, you can check out https://help.github.com/articles/creating-a-pull-request/

Good luck, and let me know if you have questions.

lafleurdeboum commented 6 years ago

OK, I think I did it - forked format-udf, and did a pull request against the format-udf script, which I let go to upstream master branch. I noticed a bit late that you had a "develop" branch, that I could have pulled my request in. Hope it doesn't bother the process. Anyway the bug fix is pretty trivial ; I also tested it on a real hard drive before submitting it. Comments appreciated !

JElchison commented 6 years ago

Everything looks great. Thanks!

Your name has been automatically added to our list of contributors: https://github.com/JElchison/format-udf/graphs/contributors