search

JElchison / format-udf

Bash script to format a block device (hard drive or Flash drive) in UDF. The output is a drive that can be used for reading/writing across multiple operating system families: Windows, macOS, and Linux. This script should be capable of running in macOS or in Linux.
GNU General Public License v2.0
509 stars 48 forks source link

add linux mmcblk0 sdcard support fixes #46 #49

Closed walterav1984 closed 4 years ago

walterav1984 commented 4 years ago

Some SDcard readers identify the SDcard block device with /dev/mmcblk0 or /dev/mmcblk1 instead of /dev/sdX used by regular USB storage devices. Partitions on these blockdevices are identified with an aditional 'p' like the nvme.

This fixes #46 , however I cannot verify mmcblk1 since I only have 1 device.

JElchison commented 4 years ago

Hi again @walterav1984! Thanks for this PR. I appreciate your investment in this project!

I have chosen to fix #25, #27, and #46 using a method that incurs less technical debt.

I invite you to review my proposed combined fix here: https://github.com/JElchison/format-udf/compare/develop

...and to test the fix using the version in this branch: https://github.com/JElchison/format-udf/tree/develop

If merged, these proposed fixes obsolete PRs #49 and #50.

I look forward to your comments. Thanks!

walterav1984 commented 4 years ago

Thanks for taking on the other issues as well. Did some simple testing using this new develop branch (with & without /dev/ prefix) on Debian 10 amd64 with 'nvme0n1' device, Ubuntu 16.04.6 amd64 'mmcblk0' and Ubuntu 19.10 amd64 'sdb' and devices get formated succesful.

Have you tested macOS?

JElchison commented 4 years ago

Thanks!

I have Travis CI set up to test on Linux, and I manually tested the new changes on a physical macOS machine I have here. I have one more battery of tests that I'd like to run manually on macOS, after which I'll merge develop into master.

Thanks again for your review, testing, contribution, and interest!

walterav1984 commented 4 years ago

Did successfull test devel version ba6ceb8 on macOS High Sierra 10.13.6, Yosemite 10.10.5 and El Capitan 10.11.6 with and without "/dev/" prefix both for disk5/disk6, with the creation of making writable UDF volumes accessable by Windows10 and Ubuntu 19.10 amd64 linux.

Thanks for sharing this cross platform compatible UDF format tool for increased file exchange between these rivaling platforms.

JElchison commented 4 years ago

Thank you for this testing! I had surgery yesterday, so I will merge this into master once I'm back on my feet.