JF002 / cfRFM69

RFM69 driver library for ESP32/Arduino
MIT License
7 stars 2 forks source link

Power settings - some mistakes - please fix #3

Open Codedial06 opened 2 years ago

Codedial06 commented 2 years ago

Hi,

there are a few things to fix in your source files (in RFM69.cpp):

  1. please delete line 311 it is forbidden to set register 0x11 like that: WriteRegister(static_cast<uint8_t>(0x11), static_cast<uint8_t>(0xff));

  2. in line 364 Registers::ListenRxDuration is the wrong register, please set it to 0x11

  3. in line 365 there is one | at the end too many, please remove it: static_cast<uint8_t>((outputPower & 0x1F) | (pa2 ? (1 << 5) : 0) | (pa1 ? (1 << 6) : 0) || (pa0 ? (1 << 7) : 0)));

now it should work, thanks for your code