JFKingsley / GodPowers

The official repo for the GodPowers bukkit plugin
bit.ly/GodPowers
6 stars 3 forks source link

Gorgon Head #6

Closed cookiem42 closed 10 years ago

cookiem42 commented 10 years ago

I don't know if it possible or not, but can you make a item that uses the /medusa command when you hold it? So when you look at a player while holding said item, they freeze.

zachbr commented 10 years ago

It can be done but I'm not 100% sure how well it would fit with the plugin. Or even what material would make sense. I'm hesitant at best. Care to elaborate on your reasoning or how you would see it working?

JFKingsley commented 10 years ago

Yeah, I share the same questions, it's certainly a very easy patch, just one that i'm not entirely sure would contribute to play in any meaningful way. A little detail would be useful on this one.

cookiem42 commented 10 years ago

Maybe a player head. And it would be cool, if you have that head you don't need the permission to do the /medusa command.

zachbr commented 10 years ago

I'm still unsure of this. I don't think it should necessarily be closed because as an idea it does hold some value. Someone carrying the head of Medusa being able to use it as if they had the power directly or something. As far as permissions go, I don't really want to not assign a permissions node. We can perhaps add a separate node but I'd really like to keep it permissions based. godpowers.medusa.head or something similar. Anyway I'll certainly keep it in consideration. Any thoughts @JFKingsley?

JFKingsley commented 10 years ago

True, it's an interesting idea, but it really needs balancing somehow, it's far too OP in it's current suggested state.

I agree with Zach on the permissions thing, there's too much risk for griefing and other stuff with this as it is, removing limits just makes it crazily exploitable.

zachbr commented 10 years ago

What if you were given an item, such as a head to keep it inline with mythology, that did this but only if you were to kill a player in the Medusa list? And then, assuming you had the perms node, you could use that item, the head, to freeze people. So you kill a Medusa player, it drops their head, and if you have the node and are holding the item you get its power? That's the only place I can see this going without being ridiculously OP and still keeping it fairly inline with mythology.

cookiem42 commented 10 years ago

That sounds awesome.

cookiem42 commented 10 years ago

Oh and if it isn't too much trouble, can you make it so certain players are not affected by /medusa. It is annoying for staff. Thank you for reading :)

zachbr commented 10 years ago

Added the exempt node as it's quick and easy. In order to exempt your staff, grant their permissions group the node godpowers.medusa.exempt

Haven't even started work on the other part, that will require much more time than this to properly setup and test.

Please use this jar, at this link, as it is the latest build with the above perm node included. Please test it and confirm that it does work. http://i.destroystokyo.com/godPowers.jar Please reply back here after you test it. Thanks

zachbr commented 10 years ago

@cookiem42 Does the above build work as intended? That is does it prevent groups with the node from being affected by Medusa Players?

cookiem42 commented 10 years ago

Yeah the exempt permission works

zachbr commented 10 years ago

Got the basic drop handling working. As is, it will only drop if the config value is set to true, and a player is killed by another player with a sword. The actual functionality isn't there yet but it's coming. It's a tad slow as I only have one minecraft account but I'm confident we can get this working soon.

medusaheaddrop_lore

EDIT: And the player that drops the head is removed from the Medusa list if the head drops, which should cut down on the amount of these floating around, but again, they will have a perms node so it won't be too bad even if they are.

zachbr commented 10 years ago

Second part is being a bit more interesting. PlayerItemHeldEvent seems... unreliable at best. Definitely going to be playing with this some more.

Edit: Nope it just helps when you use it right :) EditEdit: We are close!

zachbr commented 10 years ago

@cookiem42 Potentially working now? Use this jar and grant those who you want to be able to use it godpowers.medusa.usehead also, make sure the config value MedusaDropHead is set to true. Also, I left debug messages on for the time being, please test this with others when you get the chance, I don't have multiple MC accounts or the playerbase to test this properly. You can obtain a jar from here, as always, thanks :)

http://i.destroystokyo.com/godPowers.jar

Also if you're interested in the source code behind it, the branch can be found here: https://github.com/JFKingsley/GodPowers/tree/MedusaDropHead

cookiem42 commented 10 years ago

It works:D thanks so much for putting this in

zachbr commented 10 years ago

It still needs a little work. There are ways to fool the system yet (such as moving it around in the inventory) but it is a very good start.

zachbr commented 10 years ago

Just an update on this. I've been busy lately but I plan to work on cleaning it up and general polish soon. Friday, in all likelihood.

If we can get this working in a polished and clean way, this could definitely be another big feature for us.

Edit: s/Friday/Saturday

zachbr commented 10 years ago

Updated the jar on my server again. Now handles inventory movement. Feel free to play with it more.

http://i.destroystokyo.com/godPowers.jar https://github.com/JFKingsley/GodPowers/tree/MedusaDropHead

zachbr commented 10 years ago

Officially merged into master, you'll see this in 3.6.