search

JFLarvoire / SysToolsLib

A library of Windows and Linux system management tools
Apache License 2.0
327 stars 95 forks source link

PSService - Stop on shutdown #32

Closed webalexeu closed 3 months ago

webalexeu commented 2 years ago

Hello,

It seems that service is not stopping properly when we shutdown the server (Working fine when we stop the service manually) I don't see the stop going in SCMStop neither the exit message send to the pipe, only actions coming from finally loop.

Is this a known issue? Second question, do you plan to integrate the pre-shutdown notification?

Thank you for your work

webalexeu commented 2 years ago

OnShutdown method is not implemented and that's probably explaining the behaviour

Daymarvi commented 2 years ago

Hello @JFLarvoire , together with @webalexeu we worked on the code to add the OnShutdown() and the "OnPreShutdown()"

https://github.com/JFLarvoire/SysToolsLib/pull/33

JFLarvoire commented 2 years ago

Hello, Thanks for the proposal. I'm a bit short on time now, and I'll review this in a few days.

JFLarvoire commented 3 months ago

I've merged in PR #33, and implemented most of the changes proposed in #issuecomment-1112394038.