search

JFXtras / jfxtras-styles

Java, JavaFX themes or look and feels. Currently contains JMetro theme.
https://pixelduke.com/java-javafx-theme-jmetro/
642 stars 144 forks source link

Hidding crosses from input-text when are read-only. #182

Closed volkal1 closed 3 years ago

volkal1 commented 3 years ago

180

dukke commented 3 years ago

Hi @volkal1

Sorry for the late reply, but I caught the virus and was out of action for some days (with work pilling up).

I just ran ThemeTester sample, just as it is now (without your fix) and read-only Textfields don't show a cross. So in what circumstances exactly does that happen? And, if there is indeed a case where this fix will fix a problem (there's probably a specific case you've identified), could you add a sample in the jmetro--samples subproject that illustrates that problem happening (which potentially won't happen after your fix)? I always like to add small samples for every fix or change. It's a way to quickly check if the change is working fine (no side effects, etc).

Thanks! best regards,

dukke commented 3 years ago

Hi @volkal1 Could you give some feedback on my comments please?

Thanks,