search

JFXtras / jfxtras-styles

Java, JavaFX themes or look and feels. Currently contains JMetro theme.
https://pixelduke.com/java-javafx-theme-jmetro/
643 stars 144 forks source link

Fix for exception when using ListSpinner #186

Closed ThomasDaheim closed 3 years ago

ThomasDaheim commented 3 years ago

See https://github.com/JFXtras/jfxtras/issues/124 for more details.

Updates the skin path to the correct one.

dukke commented 3 years ago

Hi Thomas,

Thanks for find this bug and fixing it and for the PR.

Could you also file a PR against the 11 branch? So this fix is also available for JMetro 11 versions.

Thanks again.

ThomasDaheim commented 3 years ago

@dukke: Somehow, I have the nagging feeling there is something I should have done here but didn't do...

dukke commented 3 years ago

Hi Thomas,

Ahah yeah.. no worries. 🙂

I was asking whether you could also file a PR for the 11 branch which is now the "master" branch.

Meanwhile, I made some changes to the branch structure of JMetro and I think Github automatically closed this PR because of that (it wasn't me).

The master branch is now for the Java 11 version. The Java 8 version location changed, it is now in branch "jdk-8" which is in maintenance mode.

If you could file a new PR for the master branch (for Java 11) that would be great.

Thanks again,