search

JFXtras / jfxtras-styles

Java, JavaFX themes or look and feels. Currently contains JMetro theme.
https://pixelduke.com/java-javafx-theme-jmetro/
642 stars 144 forks source link

Fix for issue #210 #211

Closed ThomasDaheim closed 2 years ago

ThomasDaheim commented 2 years ago

See https://github.com/JFXtras/jfxtras-styles/issues/210

NomadicDeveloper22 commented 2 years ago

Any word on this getting merged?

dukke commented 2 years ago

Hi @ThomasDaheim

Truly sorry for the late reply, I've been very busy with my work!

Can you make that one change I suggested in the review to the PR?

Thanks and sorry again.

ThomasDaheim commented 2 years ago

Hi @dukke

No worries, we all have a real job to take care of as well ;-)

Somehow I can't find your comment? Probably me trying to fix things on a Sunday... What change did you suggest?

dukke commented 2 years ago

Hey @ThomasDaheim , good to hear from you again.

Minor change, I just suggested that you simply remove the commented out line of code that was previously causing issues (instead of commented it out just remove it entirely):

 /*-fx-skin: "impl.jfxtras.labs.internal.scene.control.skin.ListSpinnerCaspianSkin";*/

Thanks!

ThomasDaheim commented 2 years ago

Done

dukke commented 2 years ago

Thanks @ThomasDaheim !