search

JFXtras / jfxtras-styles

Java, JavaFX themes or look and feels. Currently contains JMetro theme.
https://pixelduke.com/java-javafx-theme-jmetro/
642 stars 144 forks source link

Add click animation to MenuButton? #55

Open dukke opened 5 years ago

dukke commented 5 years ago

Not sure, but probably we should add a click animation to the MenuButton. The same animation that Button has (shrinks when pressed).

MairwunNx commented 5 years ago

In processing ... 😊

dukke commented 5 years ago

Finish withstanding PRs first Pavel, please 😊

MairwunNx commented 5 years ago

Done! I today create PR, but, you need for first accept "Button and ToggleButton fixes" and then you can accept PR "MenuButton shrink animation additions", because MenuButton has dependensity what added in "Button and ToggleButton fixes", ok? It two PR ("Button and ToggleButton fixes" and "Button and ToggleButton fixes") be created today, i think it good changes 👍 👍 👍 👍

dukke commented 5 years ago

OK, but first the issue Pavel. Please add the issue about the bug you are experiencing with Button and ToggleButtons so we can both discuss them. I'm not having those issues myself.

After we do this I think we need to focus on finishing the withstanding PRs so that they don't pile up, please :)

Thanks :)

MairwunNx commented 5 years ago

Ok, i understand you :) Not, it last PR's :))) (last = Button and ToggleButton fixes and MenuButton animations ... ) no more ! :)

100% all PR's we can close in friday! 🥇

dukke commented 5 years ago

That would be great 👍 👍 👍 👍 👍

File the issue for the bug first, please :) I think that's the most important thing we need to focus right now. If the bug exists (not doubting you, but could be caused by another library or something) we need to fix it first. A bug free release should be a primary focus.

Thanks Pavel!! 👍

MairwunNx commented 5 years ago

Resolved in #59