search

JFXtras / jfxtras

A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.
http://jfxtras.org
Other
599 stars 123 forks source link

Change jfxtras-test-support to test scope #128

Closed samypr100 closed 3 years ago

samypr100 commented 3 years ago

Example PR for #127

Also removed scope from openjfx in order to let the parent pom dependency management decide that

tbee commented 3 years ago

If you do this (I have this change in place as well) the required --add-opens use an illegal reference to the test-support jar. It now is part of the classpath and not of the modulepath. (See the error lines in the surefire output.)

If you then add a module-info.java to src/main/test containing the test-support module to fix that, the tests fail on a NPE because the CSS resources are not found anymore.

If instead you remove the module-info.java and no longer make it a module, the compiler fails with a line that it cannot generate a module name from the test-support jar's name.

samypr100 commented 3 years ago

Saw your latest commit, I'll close this PR since the changes were similar.