Closed Maxoudela closed 9 years ago
Change is ok, I'm missing tests. Or at least one test in CalendarTextFieldTest
I have added a test in CalendarTextField. Should I create some file in order to write the same test in LocalDateTextField and LocalDateTimeTextField?
I am intending to run the same tests on the LocalDate*TextFields as well, so it would be great if you would create these test classes add the test there as well. Yes.
On 20-5-2015 12:27, Maxoudela wrote:
I have added a test in CalendarTextField. Should I create some file in order to write the same test in LocalDateTextField and LocalDateTimeTextField?
— Reply to this email directly or view it on GitHub https://github.com/JFXtras/jfxtras/pull/30#issuecomment-103837273.
I will create these classes and add the same test. I will also try to add the other tests as well if I can in order to do everything properly.
Well it might take some time but it's on the way :)
:+1: Thank you!
I've tried to add the same tests for LocalDateTextfield and LocalDateTimeTextField. I had to remove some that were meaningless for these Controls.
Looks good! I'll merge this soon and run the tests. Thanks for the work! (The untested controls were bugging me for quite some time already.)
Merged! Great commit. Thanks!
The file CalendarPicker is displaying some bug changes but I just modified a "Yoy" into a "You" in a comment... I don't understand why the changes are outstanding like that.