JFXtras / jfxtras

A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.
http://jfxtras.org
Other
599 stars 123 forks source link

Adding "displayedCalendar" into CalendarTextField, LocalDateTextField and LocalDateTimeTextfield in order to choose which date to display. #30

Closed Maxoudela closed 9 years ago

Maxoudela commented 9 years ago

The file CalendarPicker is displaying some bug changes but I just modified a "Yoy" into a "You" in a comment... I don't understand why the changes are outstanding like that.

tbee commented 9 years ago

Change is ok, I'm missing tests. Or at least one test in CalendarTextFieldTest

Maxoudela commented 9 years ago

I have added a test in CalendarTextField. Should I create some file in order to write the same test in LocalDateTextField and LocalDateTimeTextField?

tbee commented 9 years ago

I am intending to run the same tests on the LocalDate*TextFields as well, so it would be great if you would create these test classes add the test there as well. Yes.

On 20-5-2015 12:27, Maxoudela wrote:

I have added a test in CalendarTextField. Should I create some file in order to write the same test in LocalDateTextField and LocalDateTimeTextField?

— Reply to this email directly or view it on GitHub https://github.com/JFXtras/jfxtras/pull/30#issuecomment-103837273.

Maxoudela commented 9 years ago

I will create these classes and add the same test. I will also try to add the other tests as well if I can in order to do everything properly.

Maxoudela commented 9 years ago

Well it might take some time but it's on the way :) capture

tbee commented 9 years ago

:+1: Thank you!

Maxoudela commented 9 years ago

I've tried to add the same tests for LocalDateTextfield and LocalDateTimeTextField. I had to remove some that were meaningless for these Controls.

tbee commented 9 years ago

Looks good! I'll merge this soon and run the tests. Thanks for the work! (The untested controls were bugging me for quite some time already.)

tbee commented 9 years ago

Merged! Great commit. Thanks!