search

JFXtras / jfxtras

A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.
http://jfxtras.org
Other
599 stars 123 forks source link

modified version #37

Closed toretak closed 9 years ago

jptinsman commented 9 years ago

Sorry, didn't see that you had already closed this.

Question, why was there so many unmodified changes in the PR? Was it formatting (not seeing differences like space vs tab)? If it was formatting I would recommend the repo owner include a formatting guideline or export from his IDE so contributors know the desired format.

tbee commented 9 years ago

if people indeed start contributing, then that is a good idea. Up until now it has been me, myself and one other mainly.

toretak commented 9 years ago

Sorry, I accidently made PR to your repo instead of mine. There were many changes, but not ready for publish. All of it are specific modification for specific purpose. e.g. Hour is divided to quarters, hour is larger (size in px) and appointment could have an image icon. The time substraction in TrackedPane is 10s not minutes. It's because I want to stick following appointments into same Track, that means the comment should be Pe >= Ns to Pe > Ns or Pe >= Ns to Pe-10 sec >= Ns

I use Netbeans and I using Netbeans code formatting, so it really could be ide formatting...

tbee commented 9 years ago

Yeah, I use Eclipse, so formatting definitely will be different. Do consider if any of the chances is worth merging back into JFXtras. The most important quality aspect I require for merges are tests (TestFX), to prevent regression.