new getNodeForPopup method and more

[daviddbal]

Tom,

This PR contains several commits that do the following:

• adds selectOneAppointmentCallback that is run when only one appointment is selected
• renames the callbacks I added to follow the verb-noun convention like the other callbacks in Agenda.
• adds -fx-fill colors to Agenda.css to allow me to use Rectangles as icons.
• adds getNodeForPopup and a map to back it in AgendaSkinTimeScale24HourAbstract.

The appointmentBodyPaneMap I added in the second commit has been removed.

-David

[tbee]

Where do you need the oneAppointmentCallback for? De appointments observable collection should provide the same info?

[daviddbal]

That's a good point. I can listen to changes to selectedAppointments, if it contains only one then I can do what ever I want. Is that what you mean?

[tbee]

yeah

[daviddbal]

I made the change. The selecte one appointment callback is gone.

[daviddbal]

Tom,

I changed the appointmentNodeMap to use System.identityHashCode(a). I added a clean-up listener also. The feature passes simple manual testing. I didn't add any automatic tests.

I also rebased.

Please take a look.

-David

[daviddbal]

Are the equals and hashcode methods staying or being removed?

[tbee]

Good question. On the one hand I'm a big fan of not having code that has no purpose, on the other hand, given that user may implement their own equals, it is good to have them in place to test against. But since Agenda must render two totally identical appointments separately, I think they should be removed.

[daviddbal]

Maybe they should be removed from Agenda, but put in a separate test-only Appointment implementation. That way some tests can be made to guarantee correct behavior in case a user implements another equals.