search

JFXtras / jfxtras

A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.
http://jfxtras.org
Other
599 stars 123 forks source link

refactoring to TemporalType enum #57

Closed daviddbal closed 8 years ago

daviddbal commented 8 years ago

needed to build jfxtras-labs

tbee commented 8 years ago

Yeah. The code no longer compiles after merging. The combine method is not found.

tbee commented 8 years ago

The AgendaTemporalConversionTest did not longer compile. This exactly is the reason why I'm hesitant which merging the PR's.

daviddbal commented 8 years ago

That is probably due to the method name change.  I'll fix it.  That is happening because I can't run the tests in jfxtras on my end.  I literally move the tests from jfxtras into jfxtras-labs, fix them, and then move them back.  I need to get the jfxtras tests running. -David 

On Thursday, March 10, 2016 12:04 PM, Tom Eugelink <notifications@github.com> wrote:

The AgendaTemporalConversionTest did not longer compile. This exactly is the reason why I'm hesitant which merging the PR's.— Reply to this email directly or view it on GitHub.

daviddbal commented 8 years ago

I fixed the broken tests.  I'll try to make sure I have a proper build of jfxtras and have run the tests before I do any more PRs. -David 

On Thursday, March 10, 2016 12:04 PM, Tom Eugelink <notifications@github.com> wrote:

The AgendaTemporalConversionTest did not longer compile. This exactly is the reason why I'm hesitant which merging the PR's.— Reply to this email directly or view it on GitHub.

tbee commented 8 years ago

You need to create a single or two separate new PRs. I've reverted the original one, so the new one only modifies the test and then breaks the code.