JFreegman / toxic

A Tox-based instant messaging and video chat client.
https://tox.chat
GNU General Public License v3.0
1.2k stars 153 forks source link

Excessive screen redrawing makes the program annoying / difficult to use with refreshable braille displays #194

Closed youtux closed 7 years ago

youtux commented 10 years ago

The ncurses interface continously refreshes, and the cursor goes continously around. This is at least the perception with my braille display (I am using it with BRLTTY 5.1 for the record). So the software is hardly usable, since by default the display braille follows the movements of the cursor, and even disabling this functionality, I find it very annoying. I don't have this problem with other programs like nano, irssi, ncmpc and other ncurses-based tools. Even with finch (that uses lignt of course), i have no problems. Could this be fixed? Or is this something that has to do with the design of some libraries / the program / something else in general, even not regarding design? Thank you. Some infos that might help:

the problem seems not present when not connected to the network - still, some flickering in the help screen makes the screen unconfortable to read.

Thank you very much for the attention.

My setup seems also affected by https://github.com/Tox/toxic/issues/96 so I currently am not able to get connected with this computer. I might switch to another but I would like to avoid this due to some reasons. Hoping it's appropriate to report it here, my tox id is: 7C593F402A3C8632D87AB4B948D492294C39A6A614464ECF843CA3429FB023284180472C7475 I will try to connect when I'll be able to re-join the network from here with toxic, to be precise. Thank you.

youtux commented 10 years ago

Sorry. Wanted to say: I installed openal and freeglut, but edited the makefile to not compile audio support anyway (some problems in the audio support, seemingly toxic is not synced with the toxcore API).

JFreegman commented 10 years ago

I think this might be an inherent flaw in the design of toxic. curses works by refreshing the active window a billion times per second, but toxic goes a step further by continually re-printing everything on every refresh. This is sort of a hack that allows for screen scrolling and prevents terminal resizing from breaking things.

youtux commented 10 years ago

You are very kind guys. Thank you.

ghost commented 10 years ago

I too get very noticeable flickering throughout various parts of the UI. Why is toxic refreshing constantly as opposed to only redrawing on a resize event? Or can ncurses not handle that? I saw this[0] in case it's of any help.

[0] https://stackoverflow.com/questions/13707137/ncurses-resizing-glitch

gima commented 9 years ago

Here are screen recordings of the excessive redrawing. People...

Don't blink Please, don't blink

Bottom line: Cannot deal with it. Come on guys, a seven months old bug?

JFreegman commented 9 years ago

@gima this is evidently not a very common bug, and I think that it would require a great deal of my free time to fix, which is something that I don't have much of lately.

louipc commented 9 years ago

@gima Why don't you send a patch? Thanks.

ghost commented 9 years ago

@louipc now, now, we don't want to start the "fix it yourself" trend, it would give us a bad name. However, @gima as @JFreegman said, this bug is rather uncommon and to fix it would require us to switch focus from more important things like toxcore. We ask for your patience.

Thank you.

louipc commented 9 years ago

On Mon 23 Feb 2015 13:39 -0800, mannol wrote:

@louipc now, now, we don't want to start the "fix it yourself" trend, it would give us a bad name. However, @gima as @JFreegman said, this bug is rather uncommon and to fix it would require us to switch focus from more important things like toxcore. We ask for your patience.

People need to realize that in a small open source, free software project, we're all working on this on our free time and we all have different priorities.

It's reasonable to ask for people to actually contribute to see their needs realised. If they have problems they can ask for help, but linking to some "Works on My Machine Certification Program" blog post mocking developers because they can't reproduce your bug doesn't help get it fixed.

No we don't want to start the "closed, won't fix trend" but if people are disrespecting the contributors that might start to happen. So let's nip it in the bud.

henriqueleng commented 9 years ago

I'm with this problem too, I will look for a solution

mrkiko commented 7 years ago

Seems fixed now. The cursor rarely flickers around, if at all. So I am closing this issue. Thank to the guy who helped me reporting it. I am grateful to you; and to all of you.

mrkiko commented 7 years ago

Sorry, can not close. :D