JFreegman / toxic

A Tox-based instant messaging and video chat client.
https://tox.chat
GNU General Public License v3.0
1.2k stars 153 forks source link

Fix problem with Clang build #580

Closed xWNgLWT0mQf closed 9 months ago

xWNgLWT0mQf commented 3 years ago

Fix inclusion of NAME_MAX and PATH_MAX macros. On Linux they are defined at <linux/limits.h> On Apple they may be defined at <sys/sysinfo.h>, if possible please check the apple definitions.

Signed-off-by: Josiah Mullins JoMull01@protonmail.com

xWNgLWT0mQf commented 3 years ago

It seems that GCC automatically sets PATH_MAX and NAME_MAX while Clang does not.

JFreegman commented 2 years ago

I have never had any issues with these defines when compiling with either GCC or Clang. Can you post the errors you were getting?

xWNgLWT0mQf commented 2 years ago

I apologize for the delay in my response. I hope that you find what you are looking for in the following bug. https://bugs.gentoo.org/803404

JFreegman commented 9 months ago

Closing this for inactivity. I've still never heard of anyone else having issues with this on any system - it's most likely an issue with your own environment. Please re-open in https://github.com/TokTok/toxic/ if you're still having trouble.