JFreegman / toxic

A Tox-based instant messaging and video chat client.
https://tox.chat
GNU General Public License v3.0
1.2k stars 153 forks source link

feat: add optional nickname argument to /join command #647

Open Tha14 opened 1 year ago

Tha14 commented 1 year ago

When initially joining a group chat there should be an option to define the nickname with which we will be joining said group chat. The only thing that I am not sure about is how this optional command would work out as we already have the password argument as an optional parameter. Current example: /join {GROUP_CHATID} [PASSWORD] My current idea: /join {GROUP_CHATID} [NICKNAME] [PASSWORD]

JFreegman commented 1 year ago

Both a nick and a password can contain spaces. In order to allow for both arguments you'd need to add quotes to the arguments and parse it appropriately. It's a pain in the ass and is ugly. An alternative solution could be to put an optional name argument before the ID. You would be able to exclude quotations because only one of the arguments can have 64 contiguous characters. Anything before that arg is a nick, and anything after is a password.