search

JGCRI / fldgen

Given a global mean temperature pathway, generate random global climate fields consistent with it and with spatial and temporal correlation derived from an ESM
https://jgcri.github.io/fldgen/
GNU General Public License v2.0
12 stars 6 forks source link

planned potential changes to get to v2.1 #15

Open abigailsnyder opened 5 years ago

abigailsnyder commented 5 years ago

Sometime this summer depending on staffing.

  1. Make the 1var training function capable of handling training data with NA values. Create functions for 1var residual generating and full field generating. This would be just taking all the 2var stuff I’ve written and adapting.
  2. Make a tutorial0 focused on the one step training and generating functions: one variable, two variable, data with NA values, and using a different tgav than that calculated from the data.
  3. Train TP emulators for a handful of major ESMs and put them on Zenodo. Then we can include the link to that in the github repo.
  4. Make the names of the functions in fldgen more generic: train2var instead of trainTP, using things like var1, var2 instead of T and P. The actual science is all the same - our 2 var functions should work for any 2 related variables, not just TP. So we could make the names reflect that.
rplzzz commented 5 years ago

I think eventually we need to get rid of the separate 1var and 2var versions of the API. Ultimately, what we need is a single training function that we can use to set up an emulator for 1, 2, or arbitrarily many variables.

abigailsnyder commented 5 years ago

I don't disagree, but I have a very definite idea of how I would like that to look and I have a hunch the implementation would be tough to make user-friendly. So when we get to the point of actually doing more development, we'll have to scope that out vs doing 1var, 2var for a while and then coming back to the streamlined 3 key functions (train, generateresids, generatefull)