search

JGCRI / gcamdata

The GCAM data system
https://jgcri.github.io/gcamdata/
Other
44 stars 26 forks source link

Chunk/remove lb113 #1185

Closed russellhz closed 2 years ago

russellhz commented 2 years ago

Addressing #487

Incorporated LB113 into LB163. Completely getting rid of the output from LB113 seemed more complicated. From what I saw, L113.ag_bioYield_GJm2_R_GLU is still needed because in module_aglu_L2012.ag_For_Past_bio_input_irr_mgmt, biomass tree yields are determined based on the ratios to the generic yields from L113.

Not sure what the convention is on naming, but I left the output with the prefix "LB113".

codecov[bot] commented 2 years ago

Codecov Report

Merging #1185 (03a5acf) into develop (866926a) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1185      +/-   ##
===========================================
- Coverage    95.44%   95.43%   -0.01%     
===========================================
  Files          363      362       -1     
  Lines        55248    55219      -29     
===========================================
- Hits         52730    52701      -29     
  Misses        2518     2518
Impacted Files Coverage Δ
R/zchunk_LA1321.cement.R 100.00% <ø> (ø)
R/zchunk_L145.water_demand_municipal.R 100.00% <100.00%> (ø)
R/zchunk_LB163.bio_Yield_R_GLU_irr.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f776f6...03a5acf. Read the comment docs.