JGCRI / gcamdata

The GCAM data system
https://jgcri.github.io/gcamdata/
Other
44 stars 26 forks source link

add constants to drake #1195

Closed russellhz closed 2 years ago

russellhz commented 2 years ago

add constants to drake to ensure that any changes to constants.R will be captured.

This works by cleaning the entire cache if constants has been changed (and it is not the first time drake is being used). A message is written out to inform the users

codecov[bot] commented 2 years ago

Codecov Report

Merging #1195 (9cb0eb7) into develop (5483d25) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 9cb0eb7 differs from pull request most recent head aa135e5. Consider uploading reports for the commit aa135e5 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1195   +/-   ##
========================================
  Coverage    95.49%   95.49%           
========================================
  Files          362      362           
  Lines        55142    55137    -5     
========================================
- Hits         52656    52652    -4     
+ Misses        2486     2485    -1     
Impacted Files Coverage Δ
R/driver.R 85.19% <100.00%> (+0.29%) :arrow_up:
R/zchunk_L231.proc_sector.R 91.92% <0.00%> (-0.18%) :arrow_down:
R/zchunk_L241.fgas.R 100.00% <0.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf9434c...aa135e5. Read the comment docs.

russellhz commented 2 years ago

note that failures are just due to failing old-new, which is from previous PRs