JGCRI / gcamdata

The GCAM data system
https://jgcri.github.io/gcamdata/
Other
42 stars 26 forks source link

driver_drake() fail on Windows due to file name length on gcam-v7.0 #1242

Open robbieorvis opened 1 year ago

robbieorvis commented 1 year ago

I attempted to run driver_drake() on the the latest data system for v7 but it failed due to the temporary data file names being too long. There is a comment in the driver.R file that says to re-run devtools::load_all() when running into this issue, but it does not fix the problem. This means that driver_drake() cannot currently be used on Windows with the gcam-v7.0.

Here's the error:

Error in file.rename(tmp, filename) : expanded 'to' name too long

robbieorvis commented 1 year ago

Also noting that even running driver() for the data set (using the distributed GCAM data system files in the v7 folder, produces the following error for "module_gcamusa_L270.limits":

Error in check_chunk_outputs(chunk, chunk_data, input_names, promised_outputs = po, : Some precursors for 'L270.NegEmissBudget_USA' aren't inputs - chunk module_gcamusa_L270.limits

pkyle commented 1 year ago

Sorry about that bug in module_gcamusa_L270.limits--I've posted a fix to my cloned repo that you can merge in, at https://github.com/pkyle/gcam-core/tree/gpk/bugfix/gcam7_limitsfix From a command prompt, you'll need to add that repo (and name it; I'm just calling it github_pkyle in the steps below), fetch from that repo, and then merge in the branch (which is just two very small commits): git remote add github_pkyle https://github.com/pkyle/gcam-core.git git fetch github_pkyle git merge gpk/bugfix/gcam7_limitsfix

robbieorvis commented 1 year ago

Thanks for this @pkyle.

On a related note - any plans to address the issue with file length in driver_drake() on Windows? Pretty limiting to not have that available, unfortunately.

From: pkyle @.> Sent: Friday, June 9, 2023 10:04 PM To: JGCRI/gcamdata @.> Cc: Robbie Orvis @.>; Author @.> Subject: Re: [JGCRI/gcamdata] driver_drake() fail on Windows due to file name length on gcam-v7.0 (Issue #1242)

Sorry about that bug in module_gcamusa_L270.limits--I've posted a fix to my cloned repo that you can merge in, at https://github.com/pkyle/gcam-core/tree/gpk/bugfix/gcam7_limitsfix From a command prompt, you'll need to add that repo (and name it; I'm just calling it github_pkyle in the steps below), fetch from that repo, and then merge in the branch (which is just two very small commits): git remote add github_pkyle https://github.com/pkyle/gcam-core.git git fetch github_pkyle git merge gpk/bugfix/gcam7_limitsfix

- Reply to this email directly, view it on GitHubhttps://github.com/JGCRI/gcamdata/issues/1242#issuecomment-1585424652, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK5N6SMQRPANTWJK23L7PNLXKPIZXANCNFSM6AAAAAAY7ZXW7I. You are receiving this because you authored the thread.Message ID: @.**@.>>