search

JGCRI / gcamdata

The GCAM data system
https://jgcri.github.io/gcamdata/
Other
43 stars 26 forks source link

L241.en_newtech_nonco2 TODO #650

Open kdorheim opened 7 years ago

kdorheim commented 7 years ago

L241.en_newtech_nonco2.R in the old ds contains the following

TODO: better way to handle this, probably these technologies should pull from historical data

(The code currently replaces 1975 technology coefficients with may.be.historic values from an assumption file.)

Is this something we want address later on?

russellhz commented 2 years ago

@ssmithClimate any thoughts on this issue? For some further context, this chunk is outputting emission coefficient tables for new energy technologies. The majority of these emissions come from emissions/A41.tech_coeff, although some coefficients for CO and CH4 come from historical data calculated by previous chunks.

Then some of the years (which are by default 2020) are replaced with 1975 if the "newtech" was actually used historically.

The todo is before this year replacement on line 175 (note that I don't think the second part of the comment is true, as it looks like all regions get overwritten identically):

# TODO: better way to handle this, probably these technologies should pull from historical data
# Ensure only regions that have first gen biofuels get read in
# See GitHub issue #650

# Not all of the regions started using the new technologies, "newtech", at the same time,
# some regions started using them in historical years whereas other regions started
# using them in future years. For the regions that may have been using these
# technologies in historical years replace the first model base year with the maybe
# historical value to include the historical "newtech" nonco2 parameters in the historical data.