notes on land_utils.R - Githubissues

JGCRI / gcamlandc

GCIMS Hector Land C work

0 stars 0 forks source link

notes on land_utils.R #2

Open kendalynnm opened 10 months ago

kendalynnm commented 10 months ago

This script contains a smattering of open-ended comments, questions, and commented out values above or below set values that don't have clear explanations.

[x] L6&7, f_det
[x] L18, beta
[x] L44, 48&49, rhs and q10
[x] L62, 65&66, above ground NPP
[x] L76&77, below ground NPP
[x] L216 to 231, params matching and duplicate removal
[x] L289, subdivide?
[x] L324 to 328, can be deleted?
[x] L437, see note
[x] L446, -3 in sigmoid_val equation

abigailsnyder commented 10 months ago

Parameters coming from Hector doc (https://jgcri.github.io/hector/articles/SimpleNBox.html) - sometimes different labels eg k_s,d (hector) vs f_rhs (offline)

abigailsnyder commented 10 months ago

f_agnpp for us = f_nv in hector https://jgcri.github.io/hector/articles/SimpleNBox.html

fns is a little different from our f_bgnpp because our belowground = hector soil + detritus
f_bgnpp + f_agnpp = 1

kendalynnm commented 10 months ago

L216 to 231, params matching and duplicate removal

Whether or not duplicate removal is still needed is unclear. Definitely filling blank parameters is needed.

kendalynnm commented 10 months ago

-3 comes from: "A Simple Carbon Calc"

https://github.com/JGCRI/gcam-core/blob/master/cvs/objects/ccarbon_model/source/asimple_carbon_calc.cpp