591 documents that, if you call fetchvars(hc, dates = NA) you get back the end-of run Ftot, Ca, FCO2, and Tgav data with "NA" for year.
Fixing this was slightly tricky. Previously, all these variables could be queried from their respective model components without supplying a date, and the current value internal value would be returned. This was handy but opened the door to the R user querying without a date as well. Fixing this required:
Change Ca to require a date, which means supplying the date in the two internal queries for it: in csvOutputStreamVisitor (straightforward) and OceanComponent (less so). We now ensure that the parameter C0 is written to the atmos_c_ts variable, and that it's allowed to interpolate, so that the ocean can get values correctly.
Change all forcing variables to require a date. This involved reworking forcingComponent::getData, which was a mess.
fetchvars(hc, NA) now returns an error, and it was potentially unclear, so I added a special check for this.
591 documents that, if you call
fetchvars(hc, dates = NA)you get back the end-of run Ftot, Ca, FCO2, and Tgav data with "NA" for year.Fixing this was slightly tricky. Previously, all these variables could be queried from their respective model components without supplying a date, and the current value internal value would be returned. This was handy but opened the door to the R user querying without a date as well. Fixing this required:
csvOutputStreamVisitor(straightforward) andOceanComponent(less so). We now ensure that the parameter C0 is written to theatmos_c_tsvariable, and that it's allowed to interpolate, so that the ocean can get values correctly.forcingComponent::getData, which was a mess.fetchvars(hc, NA)now returns an error, and it was potentially unclear, so I added a special check for this.Closes #591