search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
111 stars 47 forks source link

Updating output names 1: non halocarbon concentrations #610

Closed kdorheim closed 2 years ago

kdorheim commented 2 years ago

This is a part of the overhaul of the output variable names.

There are a few questions that I have run into looking at names/strings for the ch4, n2o, and atmospheric co2 stuff.

  1. the halo carbons constraints follow the pattern D_CONSTRAINT_CF4 whereas it is D_CO2_CONSTRAIN. Do we want to be consistent with our use of constrain vs constraint
  2. we discussed switching to atmos_co2 what about CO2_conc to be consistent with all of the other ghg concentration naming patterns?
kdorheim commented 2 years ago

Are vignettes checked for name changes?

ohhh great question, none of the R functions changed in this PR which is where I would expect to see changes causing vignettes to fail. All vignettes build for this PR. I have not checked the contents to see if there have been any changes to formatting which could happen if a custom color scale or labels were being used.

kdorheim commented 2 years ago

I updated the CH4, N2O concentrations to be consistent with how we are treating the CO2 concentrations vs atmospheric. Did you want to take a look at those changes or okay to merge? @bpbond

bpbond commented 2 years ago

@kdorheim OK to merge but one question first:

CONCENTRATIONS_CO2() is (i) plural (which is a little weird? Nothing else is) and (ii) really long.

Any interest in making that CONC_CO2()? Maybe that's too short 😆

kdorheim commented 2 years ago

Can totally change to CONC_ CONCENTRATIONS is pretty long, bleh but figured it was consistent with the set of `EMISSIONS` functions