Update the parameter values used in the ini

JGCRI / hector

The Hector Simple Climate Model

http://jgcri.github.io/hector/

GNU General Public License v3.0

111 stars 47 forks source link

Update the parameter values used in the ini #624

Closed kdorheim closed 2 years ago

kdorheim commented 2 years ago

In this PR update the parameter values in the ini files, add carbon cycle parameter units to the units table and adjust testing. While I have made several changes to the test_biome.R, but a number of them are still failing. I am not as familiar with how the biomes work as @bpbond or @dawnlwoodard so input would be important.

kdorheim commented 2 years ago

FYI this is relevant to @leeyap https://github.com/JGCRI/trackingC/issues/48#issuecomment-1172482226

bpbond commented 2 years ago

@kdorheim I'm taking a hard look at this. I think we have a model problem, but it's going to take me a little bit to track down.

kdorheim commented 2 years ago

that was my fear!!

bpbond commented 2 years ago

See #627 that should fix biome test errors.

kdorheim commented 2 years ago

@bpbond okay to merge?

bpbond commented 2 years ago

Look at all those lovely green checks! OK to merge.