Fixes a mistake in split_biome(), which was letting create_biome() use hard-coded values for some crucial parameters (beta, Q10, etc) that would differ from those of the base biome. This is a long-standing bug and resulted in test failures as far back as #455
More informative error messages from simpleNBox, and streamline/clean up the prepareToRun checks
Remove (in 56d95d0270817b7a38e2a5947933abaa7076607e) a test that was assuming particular behavior under warming conditions, which might not hold (specifically, mild warming can increase NPP enough to compensate for increased decomposition)
Add some extra biome-related tests
~The hector_ssp434.ini file had references to ssp343 throughout 😕 — this doesn't make sense I don't think and was causing a test failure. @kdorheim please confirm that this commit ( 19d2d71b903f8c30367dfd87af96b88c9da25cd1 ) is OK~ looks like you already fixed it
This PR
split_biome(), which was lettingcreate_biome()use hard-coded values for some crucial parameters (beta, Q10, etc) that would differ from those of the base biome. This is a long-standing bug and resulted in test failures as far back as #455simpleNBox, and streamline/clean up the prepareToRun checkshector_ssp434.inifile had references tossp343throughout 😕 — this doesn't make sense I don't think and was causing a test failure. @kdorheim please confirm that this commit ( 19d2d71b903f8c30367dfd87af96b88c9da25cd1 ) is OK~ looks like you already fixed itAll R tests pass on my machine.
Closes #456 Should fix tests in #624