@dawnlwoodard points out — cf. #531 — the problems with how Hector treats LUC emissions and NPP; basically, we currently (implicitly) handle regrowth, but accept net LUC fluxes. And that's double-counting.
Next steps:
We don't want to introduce a new double-count; so in slowparameval() reduce NPP by the ratio of the running sum to date of VegC (possibly Veg+Det) removed by LUC emissions or uptake divided by vegC at the end of spinup.
For DW testing, have a branch where LUC emissions come proportionately from veg,det,soil (as opposed to current fixed fractions, which are more realistic BBL argues but harder to test).
@dawnlwoodard points out — cf. #531 — the problems with how Hector treats LUC emissions and NPP; basically, we currently (implicitly) handle regrowth, but accept net LUC fluxes. And that's double-counting.
Next steps:
slowparameval()reduce NPP by the ratio of the running sum to date of VegC (possibly Veg+Det) removed by LUC emissions or uptake divided by vegC at the end of spinup.