search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Remove f_luc* variables #648

Closed bpbond closed 1 year ago

bpbond commented 1 year ago

Merge only after #647

If we are going to shift to proportional LUC losses, as in #647 , then we either keep the f_luc* approach as an option (but see note about complexity here) or get rid of it. That is, we can either keep or remove the ability of users to custom-specify how LUC removes/adds carbon to the terrestrial land surface.

This PR does the latter, by cherry-picking the changes from #645 into a new branch .

This has no effect on the output relative to #647 :

diff

bpbond commented 1 year ago

Updated comment above for clarity.

bpbond commented 1 year ago

@kdorheim Thank you for a36399dfc! Something has gotten borked in my roxygen2 setup, not sure what but it was throwing up all kinds of errors when I asked it to rebuild.

bpbond commented 1 year ago

Merged in latest v3_dev changes and confirming that this PR still does not change output:

diff

diff_percent

Updated comparison data in 18022cd1 and re-enabled old-new test.