search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Bring test_csv_file_reader.cpp up to date and re-enable it #653

Closed bpbond closed 1 year ago

bpbond commented 1 year ago

See #450

bpbond commented 1 year ago

Huh!

Screen Shot 2022-11-03 at 7 55 46 AM
bpbond commented 1 year ago

Disabled one test:

TEST_F(TestCSVTableReader, WrongSeparatorInRow) {
    testFile << "Date," << testVarName << std::endl;
    testFile << "2;6" << std::endl;
    testFile.close();
    Core core(Logger::SEVERE, false, false);
    // TODO: the following line segfaults on GitHub Actions
    // ASSERT_THROW(reader.process(&core, testComponentName, testVarName), h_exception);
}

We can come back to this another day.

bpbond commented 1 year ago

@kdorheim Thanks. Re opening an issue, up to you. I was thinking that having that TODO: is enough for us to find it again.