JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Integrate Woodard et al. (2021) permafrost code and parameters #655

Closed bpbond closed 1 year ago

bpbond commented 1 year ago

This PR integrates the permafrost code from Woodard et al. 2021 by @dawnlwoodard based on original code by @ashiklom . It has been entirely re-implemented for Hector v3, so while it follows the same logic there are some differences:

Performance for SSP 2.45

permafrost

Corresponding figure (not exactly, but many of same outputs; note this is using an older version of the model and the RCPs) from Woodard et al.:

Screenshot 2022-12-22 at 10 29 58 AM

Permafrost loss (a couple hundred Pg C) and temperature change (~0.4 K) look pretty good.

Thaw curve:

f_frozen

Screenshot 2022-12-22 at 10 32 12 AM

Other

Still to do

Where will existence of permafrost be documented in v3?

github-actions[bot] commented 1 year ago

“leeyabot down“

dawnlwoodard commented 1 year ago

@bpbond I remember there being a reason we separated static_c out into a pool originally and didn't just do a fraction but now I'm not remembering the justification for that. But I do know it's something we went back and forth on. Do you remember that rationale? and is it no longer relevant?

bpbond commented 1 year ago

🤷‍♂️ I don't remember. I couldn't see a good reason to keep it numerically, but at the same time that's part of why I am committing your code: so we have a close at hand, easy reference point in case we want to re-implement static_c.

github-actions[bot] commented 1 year ago

“leeyabot down“

dawnlwoodard commented 1 year ago

Okay so when I go in and remake my pf paper figure (just with 2 SSPs for simplicity), I get some pretty different results for the lowest scenario (SSP126). Do we know why this is? And do we believe that it should happen so quickly? It's refreezing much faster than it did in my paper. I know refreezing was the trickiest dynamic we had to deal with in first designing it, so it's one I'm particularly looking at to make sure the behavior makes sense in this version. (Variable labels are not plotting for whatever reason - should be Permafrost C, Thawed Permafrost C, Atmospheric CH4, Atmospheric CO2, Global Mean Temperature)

image

Also, I don't see a way to get output for the different RH variables (rh_thawedp, rh_ch4, rh_soil, rh_det) that I used in my permafrost paper analysis. Probably not critical but wanted to flag this as I did find them useful outputs to be able to look at to double check behavior.

dawnlwoodard commented 1 year ago

Also, I get a pretty different ssp126 result if I run without biomes (the first figure was made by duplicating my paper methodology with a permafrost and non-permafrost biome). Which makes me wonder why the refreeze stops in the first, but not in this. That doesn't necessarily make sense to me.

image

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

github-actions[bot] commented 1 year ago

“leeyabot down“

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

bpbond commented 1 year ago

@kdorheim Draft permafrost vignette created in 01d9db83d7b0034163733336db9f3686752bf974 and is here: https://rpubs.com/bpbond/994470

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

dawnlwoodard commented 1 year ago

@kdorheim @bpbond the permafrost vignette doesn't mention running with biomes, which I believe is important to getting accurate permafrost results. Can this be added? I can share examples of how to do this if helpful.