Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

codecov-commenter commented 1 year ago

Codecov Report

Merging #676 (09c7b93) into master (3adf0d1) will decrease coverage by 1.42%. The diff coverage is 84.28%.

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   81.12%   79.71%   -1.42%     
==========================================
  Files          54       61       +7     
  Lines        5017     5964     +947     
==========================================
+ Hits         4070     4754     +684     
- Misses        947     1210     +263

Impacted Files	Coverage Δ
inst/include/h_reader.hpp	`0.00% <0.00%> (ø)`
inst/include/carbon-cycle-model.hpp	`25.00% <25.00%> (-2.28%)`	:arrow_down:
inst/include/avisitor.hpp	`65.00% <65.00%> (+65.00%)`	:arrow_up:
inst/include/tvector.hpp	`65.71% <65.71%> (-10.05%)`	:arrow_down:
R/messages.R	`95.45% <71.42%> (-4.55%)`	:arrow_down:
inst/include/tseries.hpp	`78.22% <78.22%> (-12.78%)`	:arrow_down:
inst/include/fluxpool.hpp	`80.35% <80.35%> (ø)`
inst/include/unitval.hpp	`82.60% <82.60%> (-8.09%)`	:arrow_down:
inst/include/message_data.hpp	`83.33% <83.33%> (-4.91%)`	:arrow_down:
inst/include/simpleNbox.hpp	`92.68% <92.68%> (+2.36%)`	:arrow_up:
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kdorheim commented 1 year ago

This is the PR containing all of the developments post v2.5 release, it has been a large and lengthy process. Many developers have worked on this PR not limited to but including @bpbon, @leeyap, @dawnlwoodard, @skygering, @ashiklom, and @pralitp. At least 73 peer-reviewed PRs were merged into this branch.

The major changes are noted in the News section of the online documentation and will be further documented in the Hector v3 manuscript that is currently in prep (final manuscript information to be added here after publication). Since the quality analysis was completed during each stage of development and for detailed questions, refer to the individual PR where the development was completed. The documentation included in this PR will provide some wholistic general information about Hector behavior changes and performance.

Here is a comparison of Hector v2.5 and v3 driven with the same total RF constraint, this shows that Hector v3 runs warmer than Hector v2.5 by an average of 0.04 deg C during the historical period and 0.18 deg C during the future period.