search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
113 stars 47 forks source link

Old rcmd.yml -> R-CMD-check.yaml (newest usethis) #677

Closed bpbond closed 1 year ago

bpbond commented 1 year ago

per our discussion on Slack

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

github-actions[bot] commented 1 year ago

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (4c41d6e).

bpbond commented 1 year ago

@kdorheim I didn't change pkgdown.yaml and am confused as to why it's failing

kdorheim commented 1 year ago

Hmmm okay that is concerning and it looks like the error being thrown may be related to the problem we were seeing yesterday with the failing unit tests, for some reason some the relative path within the ini files to the csv tables are failing..... which is strange because it was working before the permafrost work was merged in. Which makes me wonder was there anything we changed in that branch that affected the way the core was read in? Or could there have been a change in the virtual environment we are running the tests/deployment on that led to this error?

bpbond commented 1 year ago

which is strange because it was working before the permafrost work was merged in.

Well, it worked after too — look at the #676 checks

kdorheim commented 1 year ago

Good point okay well I just relaunched the last running pkdown and it failed

looking at the job setup I might have found the difference....

WORKING PKGDOWN JOB

Current runner version: '2.300.2'
Operating System
  Ubuntu
  [2](https://github.com/JGCRI/hector/actions/runs/3990041677/jobs/6843202699#step:1:2)2.0[4](https://github.com/JGCRI/hector/actions/runs/3990041677/jobs/6843202699#step:1:4).1
  LTS

FAILED PKGDOWN JOB 

Current runner version: '2.301.1'
Operating System
  Ubuntu
  [2](https://github.com/JGCRI/hector/actions/runs/4007696409/jobs/6880890122#step:1:2)2.0[4](https://github.com/JGCRI/hector/actions/runs/4007696409/jobs/6880890122#step:1:4).1
  LTS

could it be related to the change in the runner version?

bpbond commented 1 year ago

could it be related to the change in the runner version?

🤷 possible I guess? Not sure how we'd test this though.