search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Carbon tracking vignette and permafrost c pool #699

Open kdorheim opened 1 year ago

kdorheim commented 1 year ago

Looking at the carbon tracking vignette there is some unexpected behavior in the first figure, without the permafrost module activated wouldn't we expect the permafrost carbon pool to be 0?

dawnlwoodard commented 1 year ago

what's the total amount of carbon in there? Like is it some miniscule amount or an actually substantial quantity? And does the ini file the run is using show 0 for the pool?

kdorheim commented 1 year ago

Ah! Good catch @dawnlwoodard! The total (sum of all source_name)permafrost_c is 0 over the entire run. So it is behaving as expected not a bug which is great news. Okay well may be in that case we should update the vignette with a note explaining this results/may be not include the permafrost_c pool in the plot?

dawnlwoodard commented 1 year ago

Great! Glad it was that easy haha. But yes sounds like the vignette should probably be updated to not include that plot to avoid confusion.