JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Fix incorrect weighting used for permafrost pool adjustment #720

Closed bpbond closed 6 months ago

bpbond commented 6 months ago

The simpleNbox::stashCvalues function was using incorrect biome weights when adjusting the permafrost pools. This resulted in extremely bad behavior when using more than a single biome.

This initial PR is a straight bug fix, and should not change main behavior at all (because permafrost remains disabled). I'll open a second PR to evaluate the effects of turning on permafrost by default in v3.

Part of #675

github-actions[bot] commented 6 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.0.0 (9aebf67).

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ea644b) 79.72% compared to head (3df6b20) 79.72%.

:exclamation: Current head 3df6b20 differs from pull request most recent head f86983b. Consider uploading reports for the commit f86983b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #720 +/- ## ======================================= Coverage 79.72% 79.72% ======================================= Files 61 61 Lines 5978 5978 ======================================= Hits 4766 4766 Misses 1212 1212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.0.0 (9aebf67).