JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

Update key parameters after v3.2 calibration #729

Closed bpbond closed 4 months ago

bpbond commented 4 months ago

Update the INI files to reflect calibrated values reported by @kdorheim in #728 .

This changes the model behavior in mostly good ways:

cal

github-actions[bot] commented 4 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a004).

github-actions[bot] commented 4 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a004).

github-actions[bot] commented 4 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a004).

bpbond commented 4 months ago

Reverting b21e1d5 to let leeyabot comment

bpbond commented 4 months ago

Ummm not sure why leeyabot is failing when it succeeded before... @kdorheim ?

github-actions[bot] commented 4 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a004).

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (dev@738257a). Click here to learn what that means.

:exclamation: Current head 3f3bca3 differs from pull request most recent head 23df7ab. Consider uploading reports for the commit 23df7ab to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #729 +/- ## ====================================== Coverage ? 80.15% ====================================== Files ? 61 Lines ? 5992 Branches ? 0 ====================================== Hits ? 4803 Misses ? 1189 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.