JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
111 stars 47 forks source link

Fix a minor numeric inconsistency in the hector vignette #739

Closed mgondan closed 5 months ago

mgondan commented 5 months ago

Beta = 0.36 seems incorrect, isn't it 0.53?

beta <- fetchvars(core, NA, BETA())
beta
##              scenario year variable value      units
## 1 Unnamed Hector core   NA     beta  0.53 (unitless)

(...) The current value is set to 0.36 (note that it is a unitless quantity, hence the (unitless) unit).

bpbond commented 5 months ago

Good catch. Thanks for the contribution @mgondan !

mgondan commented 5 months ago

The failure of the check seems to be unrelated (?)

kdorheim commented 5 months ago

@mgondan thanks for catching that! the failed check is not a related issue will merge shortly