search

JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
111 stars 47 forks source link

RF scalar effect not reported in respective output #743

Closed kdorheim closed 2 months ago

kdorheim commented 3 months ago

Adjusting RF using the volscl and alpha does not affect the RF_vol or RF aerosol results returned as output, it does have the intended effect the global temp.

Changing volscl

image

Changing alpha

image

This seems incorrect; I would think that we would want the RF values to reflect what the temperature component is seeing... It is because we adjust the total forcing in the temperature component here instead of in the forcing component.

bpbond commented 3 months ago

Agreed.

ssmithClimate commented 2 months ago

Note that it will be important to point this out to users that these parameters have moved.

Question: Will hector throw an error if an undefined parameter is read in the .ini file? (e.g. if a user uses an old .ini file with these parameters in the wrong place?)

ptrscll commented 2 months ago

I just checked, and Hector does throw an error. When using an old .ini file, I got the following error message:

Error: While parsing hector input file C:\Users\scul468\Documents\repos\hector-run-archive\hector-V3.2.0\input\hector_ssp245.ini: msg:      Could not parse var: volscl - Unknown variable name while parsing temperature: volscl
func:   setData
file:   temperature_component.cpp
ffile:  temperature_component.cpp

line:   189
kdorheim commented 2 months ago

@ssmithClimate, and for that reason, this would be merged into dev and would be part of a larger release since it would be a code-breaking change!