search

JGCRI / moirai

Moirai - Land Data System
Other
6 stars 1 forks source link

Set up R package and CI tests for v4.0.0 #15

Closed crvernon closed 4 years ago

crvernon commented 4 years ago

This pull request accomplishes the following:

Resolves #13

kanishkan91 commented 4 years ago

@aldivi @crvernon

I have now closed the other pull request. Chris, I have also tried to address your comments on the earlier one namely,

  1. I have switched from data.frame to data.table to increase processing speed.
  2. I have added a sys.time for each of my function that prints the time the test took.
  3. I have made housecleaning edits to clean up nomenclature etc as requested.

Build is passing. Let me know what you think

crvernon commented 4 years ago

@kanishkan91 let me know when you remove the print and sys.time calls and I will approve. Thanks!

kanishkan91 commented 4 years ago

@crvernon Forgot to notify you about this, but I have taken out the print statements and this is ready for the merge, Thank you!

crvernon commented 4 years ago

@kanishkan91 Go ahead and merge this and delete the build-r-package branch. Well done!