JGCRI / trackingC

Where does fossil fuel C end up, and how does that change with changing parameters?
MIT License
3 stars 0 forks source link

Addressing reviewer comments #71

Closed leeyap closed 1 year ago

leeyap commented 1 year ago

This PR includes changes to address technical issues raised by reviewers.

  1. We implement four new ocean parameters (TT, TWI, TID, TU) to better address the parameter space for ocean carbon uptake.
  2. We modify our "filtering for physical realism" approach. a. Originally, we defined only one a priori collinearity, between ECS and ocean heat diffusion. In the revision, we now vary each parameter independently, i.e. without any predefined correlations, but then use a much more stringent run-filtering step (as suggested by Reviewer 3) so that covariances emerge as the posterior ensemble is extracted. b. We add additional filtering constraints, the land and ocean sinks, using data from the Global Carbon Project.
  3. We no longer use a priori parameter distributions from literature. Instead, we use the Hector v3 calibrated default values as our mean, and apply the uncertainty from literature.
  4. With the more intense filtering step, we lose a significant amount of model runs (~87% of runs fail as opposed to ~16%). To account for this, we run the model 15,000 times, up from 10,000. This leaves us with ~500 runs per SSP to perform our analysis.

Issues left to account for:

  1. Investigating the bump in airborne fraction
  2. Final code proofread, remove unneeded comments, make existing comments more clear
bpbond commented 1 year ago

Final code proofread, remove unneeded comments, make existing comments more clear

We could run the code through the styler package, which would format it in a consistent style.

Edit: nm, I take this back. Your code is already well formatted and fine.