JGCRI / xanthos

An extensible global hydrologic framework
Other
32 stars 16 forks source link

Documentation and implementation of `runoff_file` and `alt_runoff` #66

Open thurber opened 2 years ago

thurber commented 2 years ago

Hello,

A postdoc user of Xanthos pointed out this issue to me. They were trying to reproduce the example run but with user-provided PET and RUNOFF files, but a few things conspire to prevent this:

1) The documentation here describes a runoff_file setting under the [Runoff] configuration tag. As far as I can see in the code, this setting is totally ignored. Instead, one needs to use the [Routing] [[mrtm]] alt_runoff setting.

2) Even so, if pet_module = none and runoff_module = none, neither the pet_file nor the alt_runoff file get passed on to the routing module (or the result files).

I will submit a Pull Request that can fix this issue for this particular use case, but I'm not as familiar with the broader context of the model so you may wish to address in a different way!

thurber commented 2 years ago

67 is a potential fix for this

yvettelkxii commented 5 months ago

thank you for your contribution,but still I can't get the program to read my own runoff data. Could you teach me more about it? My email is liukexii@163.com