search

JGCarroll / pinta-snap

MIT License
5 stars 5 forks source link

Update for Pinta 2.1 #10

Closed cameronwhite closed 1 year ago

cameronwhite commented 1 year ago

I'm planning to release 2.1 shortly, so for now the commit hash is the latest commit from the release-2.1 branch

The main change is updating to .NET 7, although .NET 6 is still supported by Pinta if there are any issues with this

Other notes / questions:

JGCarroll commented 1 year ago

Does anything need to be enabled for the XDG screenshot portal support?

No, all the Portals are allowed if a snap has the Desktop interface connected, and the GTK_USE_PORTAL=1 or more recent GDK_DEBUG=PORTAL variables don't matter in Pinta's case since the call isn't done via GTK.

(And GTK_USE_PORTAL=1 would become the default again when the snap is rebuilt, for the file open/close interfaces).

Optionally, webp-pixbuf-loader could be included for WebP support (this is now a suggested dependency for Pinta), but this isn't required. It's not in the 20.04 repo so may be a bit more work to add

It's likely trivial to update this snap to 22.04, which I believe has that package in the official repo's. I think it also has .NET 6 in the official repo's too, which we could have used. But if you prefer the idea of using NET 7 then that's fine too, we're a snap, the defaults sources don't bother us!

I'll merge this as is and double up with an update to 22.04 later today, hopefully with webp support.

JGCarroll commented 1 year ago

Updating to Core22 was trivial. https://github.com/MrCarroll/pinta-snap/commit/bc29066ed5c2e19521d4f50b1b0f089171414f19

Unfortunately, looking into how the pixbufs work properly, simply including the webp package into the snap isn't enough. From my experimentation, you can't easily have two different pixbufs paths; and the Gnome extension likes to take precedent. From a technical, community, and maintenance perspective; it's likely easier to get webp added to the Gnome platform content snap than it is to add it to the Pinta snap directly.

Otherwise, revision 23, currently on the beta channel, is likely good to go to be promoted to stable; but I'll allow you to take over actually promoting it to stable from here so you can align with other packages & etc.

Happy new year btw :)

cameronwhite commented 1 year ago

Happy new year! Thanks for all the investigation and updates! 😄 I'll promote that build once things are ready to go - seemed good in my testing